5165 add print picklist#5188
Conversation
| @@ -1,3 +1,5 @@ | |||
| require "prawn/table" | |||
There was a problem hiding this comment.
lack of this was tossing an error for me locally
| end | ||
|
|
||
| let(:formatted_date_range) { date_range.map { _1.to_fs(:date_picker) }.join(" - ") } | ||
| let(:formatted_date_range) { date_range.map { it.to_fs(:date_picker) }.join(" - ") } |
There was a problem hiding this comment.
calling this out, as no idea why this was picked up by the linter. I didn't mess with these files?
| end | ||
|
|
||
| let(:formatted_date_range) { date_range.map { _1.to_fs(:date_picker) }.join(" - ") } | ||
| let(:formatted_date_range) { date_range.map { it.to_fs(:date_picker) }.join(" - ") } |
There was a problem hiding this comment.
calling this out, as no idea why this was picked up by the linter. I didn't mess with these files?
|
|
||
| context "with manufacturer donations in the last year" do | ||
| let(:formatted_date_range) { date_range.map { _1.to_fs(:date_picker) }.join(" - ") } | ||
| let(:formatted_date_range) { date_range.map { it.to_fs(:date_picker) }.join(" - ") } |
There was a problem hiding this comment.
calling this out, as no idea why this was picked up by the linter. I didn't mess with these files?
| end | ||
|
|
||
| let(:formatted_date_range) { date_range.map { _1.to_fs(:date_picker) }.join(" - ") } | ||
| let(:formatted_date_range) { date_range.map { it.to_fs(:date_picker) }.join(" - ") } |
There was a problem hiding this comment.
calling this out, as no idea why this was picked up by the linter. I didn't mess with these files?
| end | ||
|
|
||
| let(:formatted_date_range) { date_range.map { _1.to_fs(:date_picker) }.join(" - ") } | ||
| let(:formatted_date_range) { date_range.map { it.to_fs(:date_picker) }.join(" - ") } |
There was a problem hiding this comment.
calling this out, as no idea why this was picked up by the linter. I didn't mess with these files?
| end | ||
|
|
||
| let(:formatted_date_range) { date_range.map { _1.to_fs(:date_picker) }.join(" - ") } | ||
| let(:formatted_date_range) { date_range.map { it.to_fs(:date_picker) }.join(" - ") } |
There was a problem hiding this comment.
i don't know why rubocop linted on these...i didn't open them?
|
It passes my functional testing. Over to @dorner for technical comments. |
dorner
left a comment
dorner
left a comment
There was a problem hiding this comment.
One request re the specs. Thanks so much for adding tests to related code - it's great that you're leaving the repo in a better state than you came in. :)
| end | ||
|
|
||
| it 'should render a link if there are unfulfilled requests' do | ||
| visit requests_path |
There was a problem hiding this comment.
This can be a request test - system tests are heavier and likelier to flake out.
There was a problem hiding this comment.
Glad you suggested this -- this test case was already covered by spec/requests/requests_requests_spec.rb
There was a problem hiding this comment.
@dorner let me know if you want anything else here -- looks gtg to me 🤷
|
@bsbonus: Your PR |
* Test: Adds missing test coverage for 'print unfulfilled' request UI * Test: Adds missing tests for requests controller #print_unfulfilled * Test: Adds overlooked cases for picklist pdf * Feature: Adds routing for new print picklist * Feature: Adds print_picklist to requests controller * Feature: Adds links to UI to access print_picklist * Docs: Adds placeholder for update to picklist docs until PR is finalized * Feature-5165 update docs to reflect new print individual picklist * Fixes rubocop issues * Removes duplicate spec case
3 participants
Checklist:
X I have performed a self-review of my own code,
X I have commented my code, particularly in hard-to-understand areas,
X I have added tests that prove my fix is effective or that my feature works,
X New and existing unit tests pass locally with my changes ("bundle exec rake"),
X Title include "WIP" if work is in progress.
X I acknowledge that I will not force push my branch once reviews have started.
Resolves #5165
Description
Adds ability for bank users to print out pdf of individual donation requests, not just the bulk "unfulfilled" pdf download.
Type of change
X New feature (non-breaking change which adds functionality)
X This change requires a documentation update
How Has This Been Tested?
Both through UI testing and automated tests. Essentially:
Screenshots